Martin: I find one minor issue in MdePkg/Include/Uefi/UefiSpec.h. The first stamen is that This include file must contain things defined in the UEFI 2.3 specification. It should be UEFI2.4. Other change looks good. Reviewed-by: Liming Gao <liming....@intel.com>
Thanks Liming -----Original Message----- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Wednesday, July 24, 2013 7:41 PM To: Gao, Liming; Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net; Harry Liebel Subject: RE: [PATCH] MdePkg: Add AArch64 support Thanks a lot Liming for this useful feedback. Please find the new patchset that addresses the questions you raised. 1. The AArch64 PXE code is actually defined by http://www.ietf.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml#proc essor-architecture (not by the UEFI spec) 2. It is correct AArch64 Binding has been adding to the PI spec. I removed the PI related changes from the current MdePkg patch. 3. I have also removed REL_BASED_AARCH64_ADRP and REL_BASED_AARCH64_ADD relocations. They are leftovers from our initial AArch64 port and they are not supported relocations. Olivier > -----Original Message----- > From: Gao, Liming [mailto:liming....@intel.com] > Sent: 24 July 2013 09:20 > To: Olivier Martin; Kinney, Michael D > Cc: edk2-devel@lists.sourceforge.net; Harry Liebel > Subject: RE: [PATCH] MdePkg: Add AArch64 support > > Martin: > I have some comments. > 1. Some header file describes its Reference spec version, such as > MdePkg\Include\Protocol\PxeBaseCode.h. I suggest you update its > version to UEFI2.4. > 2. For StatusCode definition update, I don't find such change in > public > PI1.3 spec. Have they been integrated into PI spec? > 3. For PeImage.h update, I don't find REL_BASED_AARCH64_ADRP and > REL_BASED_AARCH64_ADD from the latest PE/COff spec (Revision 8.3). > Could you let me where to find them? > > Thanks > Liming > -----Original Message----- > From: Olivier Martin [mailto:olivier.mar...@arm.com] > Sent: Thursday, July 18, 2013 2:00 PM > To: Kinney, Michael D > Cc: edk2-devel@lists.sourceforge.net; Harry Liebel > Subject: [edk2] [PATCH] MdePkg: Add AArch64 support > > Dear MdePkg maintainer, > please find the attached patches that add support for AArch64 (the ARM > 64-bit architecture) to MdePkg. > > 0001 - MdePkg: Add Aarch64 support to PE/COFF support > 0002 - MdePkg: Add Aarch64 architecture support > 0003 - MdePkg/PxeBaseCode.h: Add PXE Client ID for AArch64 > 0004 - MdePkg/BaseLib: Add AArch64 architecture support > 0005 - MdePkg/BaseCpuLib: Add AArch64 architecture support > > Best Regards, > Olivier > > -- IMPORTANT NOTICE: The contents of this email and any attachments > are confidential and may also be privileged. If you are not the > intended recipient, please notify the sender immediately and do not > disclose the contents to any other person, use it for any purpose, or > store or copy the information in any medium. Thank you. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
