Thanks Olivier. I just missed other references in the patch. On Mon, Aug 19, 2013 at 7:21 PM, Olivier Martin <olivier.mar...@arm.com> wrote: > Thanks for your contribution, I have just submitted your change in svn > revision 14561. > > I have also changed other references to MAX_ARM_EXCEPTION in this file. > > >> -----Original Message----- >> From: Girish K S [mailto:girishks2...@gmail.com] >> Sent: 19 August 2013 14:44 >> To: edk2-devel@lists.sourceforge.net >> Cc: Olivier Martin >> Subject: [PATCH V1] ArmPkg: AArch64: Fix wrong comparison of exception >> type >> >> During the interrupt registration comparison is made against >> max value of exception types for ARMV7, but in the common handling >> function the check is made against max value of exceptions types >> for ARMV8. This can lead to undefined behaviour during registration >> of interrupts. >> >> This patch modifies the registration function to handle only AArch64 >> exceptions. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Girish K S <ks.g...@samsung.com> >> --- >> changes in v1: >> Added the contributor Agreement tag >> >> ArmPkg/Drivers/CpuDxe/AArch64/Exception.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/ArmPkg/Drivers/CpuDxe/AArch64/Exception.c >> b/ArmPkg/Drivers/CpuDxe/AArch64/Exception.c >> index 1aac6a5..2f3837c 100644 >> --- a/ArmPkg/Drivers/CpuDxe/AArch64/Exception.c >> +++ b/ArmPkg/Drivers/CpuDxe/AArch64/Exception.c >> @@ -69,7 +69,7 @@ RegisterInterruptHandler ( >> IN EFI_CPU_INTERRUPT_HANDLER InterruptHandler >> ) >> { >> - if (InterruptType > MAX_ARM_EXCEPTION) { >> + if (InterruptType > MAX_AARCH64_EXCEPTION) { >> return EFI_UNSUPPORTED; >> } >> >> -- >> 1.7.5.4 >> > > > >
------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
