Thanks Laszlo and Olivier.
Ting, let me know if you are the right person to answer this question and if my
question makes sense. The current implementation is causing us serious
performance issues.
Thanks,
Eugene
-----Original Message-----
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, August 21, 2013 9:32 AM
To: edk2-devel@lists.sourceforge.net; Cohen, Eugene
Cc: 'Ye, Ting'
Subject: RE: [edk2] MNP PaddingSize Question
I was told Ting is the Network expert for EDK2 MdeModulepkg code.
> -----Original Message-----
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: 21 August 2013 16:31
> To: Cohen, Eugene
> Cc: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] MNP PaddingSize Question
>
> On 08/21/13 17:04, Cohen, Eugene wrote:
> > Who is the owner of the MNP component? (Or, put another way, if I
> > submit a patch to change this PaddingSize value, who will review
> > it?)
> >
> >
> >
> > The per-package owner list is not particularly helpful for
> > components that reside in MdeModulePkg since I'm assuming that there
> > isn't just
> one
> > developer that is responsible for all of these components.
>
> Prior reviewers for MNP:
>
> git log -- MdeModulePkg/Universal/Network/MnpDxe \
> | grep Reviewed-by \
> | sort \
> | uniq -c
> 3 Reviewed-by: Ouyang Qian <qian.ouy...@intel.com>
> 3 Reviewed-by: Ye Ting <ting...@intel.com>
> 1 Reviewed-by: lgao4
>
> (I believe the SVN username in the last line corresponds to "Gao,
> Liming" <liming....@intel.com>.)
>
>
> Prior signoffs:
>
> 3 Signed-off-by: Fu Siyuan <siyuan...@intel.com>
> 1 Signed-off-by: niruiyu
>
> (niruiyu --> "Ni, Ruiyu" <ruiyu...@intel.com>)
>
> Laszlo
>
> ----------------------------------------------------------------------
> -
> -------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance
> Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.c
> l
> ktrk
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
--- Begin Message ---
I’ve been tracking down a performance issue and have isolated it to this piece
of MNP initialization code:
//
// Make sure the protocol headers immediately following the media header
// 4-byte aligned, and also preserve additional space for VLAN tag
//
MnpDeviceData->PaddingSize = ((4 - SnpMode->MediaHeaderSize) & 0x3) +
NET_VLAN_TAG_LEN;
On my system this is coming up with ‘6’ (MediaHeaderSize = 0xE) which is
causing performance issues since some of the memory copies to the resulting
non-dword aligned addresses are slower. As an experiment I tried bumping this
number to ‘8’ and things worked well.
This value is used later when NET_BUFs are being allocated:
if (MnpDeviceData->PaddingSize > 0) {
//
// Pad padding bytes before the media header
//
NetbufAllocSpace (Nbuf, MnpDeviceData->PaddingSize, NET_BUF_TAIL);
NetbufTrim (Nbuf, MnpDeviceData->PaddingSize, NET_BUF_HEAD);
}
Can someone explain the purpose of PaddingSize and how that affects the later
processing of packets? Is this number a minimum value and is ok to be larger?
Thanks,
Eugene
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
--- End Message ---
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
