Any feedback on this one? > -----Original Message----- > From: Olivier Martin > Sent: 16 July 2013 05:51 > To: Jordan Justen > Cc: edk2-buildtools-de...@lists.sourceforge.net; edk2- > de...@lists.sourceforge.net > Subject: RE: [edk2-buildtools] [PATCH] Fixed calculation of BaseOfCode > in GenFw when the first code section is aligned > > Here is the new version that takes in account your comments. > > I took note of 'git send-email'; I will have a look to use it in a near > future. > ________________________________________ > From: Jordan Justen [jljus...@gmail.com] > Sent: 17 June 2013 22:37 > To: Olivier Martin > Cc: edk2-buildtools-de...@lists.sourceforge.net; edk2- > de...@lists.sourceforge.net > Subject: Re: [edk2-buildtools] [PATCH] Fixed calculation of BaseOfCode > in GenFw when the first code section is aligned > > Since you use git, maybe you could use git send-email, since it makes > it easier to code-review, and then reply and reference particular code > in the patch? > > Sent twice, but they look the same. Is that right? > > Maybe an ASSERT (FoundText) at the end of the routine? > > For comments, we usually like to waste 2 extra lines with empty // > comments. :) > > FoundText == FALSE => !FoundText > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > On Tue, Jun 11, 2013 at 3:04 AM, Olivier Martin > <olivier.mar...@arm.com> wrote: > > Dear EDK2 BaseTools maintainers, > > > > Please find this patch that fixes the calculation of the PE/COFF > header > > attribute 'BaseOfCode' when the first '.text' section is aligned. > > > > In the current code base, the alignment of the first code section is > not > > taken into account for the calculation of BaseOfCode. > > > > Regards, > > > > Olivier > > > > > > --------------------------------------------------------------------- > --------- > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > edk2-buildtools-devel mailing list > > edk2-buildtools-de...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel > >
------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
