On Mon, Nov 25, 2013 at 12:38:04PM -0800, Jordan Justen wrote: > Regarding patches 5-7, it seems like the mem-map code flow could be > more shared. It is a bit challenging to unravel things though. >
Indeed. It's a bit unfortunate that this path is shared by all users of OVMF. And from a previous email on edk2-devel I can see that QEMU / KVM is also trying to deal with this now with different approach -- modifying MemMapInitialization -- that would not work with Xen. (What is interesting is that QEMU_PEI_INFO is very similar to what I proposed for Xen in my RFC email. ;-) ) I cannot come up with a sensible solution for all platforms, so it makes sense for me to keep and maintain a separate path, given that the path is relatively short and straightforward. > I guess the only specific thing I can really point out is that > PcdPciAllowFullEnumeration should be initialized in a different patch, > and not within the mem-map init path. > Makes sense, I will fix this. Wei. ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
