On 11/27/13 20:10, Laszlo Ersek wrote: > Testing: > > - OvmfPkg, X64: > - VirtioNetDxe: > - PXE boot on libvirt's virtual network > - DataSource socket utility from AppPkg (guest to host) > - VirtioBlkDxe: booted > - Fedora 19 > - Windows 2012 R2 > - Windows 2008 R2 (SeaBIOS CSM build of OVMF) > - VirtioScsiDxe: booted > - RHEL-6 > > - ArmVExpress-RTSM-AEMv8Ax4-foundation, Aarch64 Foundation model: > - VirtioBlkDxe: booted > - Linaro OpenEmbedded 13.10 image (semihosting + virtio-blk) > - Linaro OpenEmbedded 13.10 image (virtio-blk only) > - Fedora 19 image (with EFI stub, virtio-blk only) > > Notes: > - Kept Olivier's C-u and S-o-b in the first place everywhere. > - When I touched a patch, I added my changes below Olivier's S-o-b, and > added my own C-u and S-o-b too. > - When I didn't touch a patch, and Jordan was explicitly OK with it (as > in, R-b), I added his R-b. > > Summary list of changes in v5 (in the order visible in the squashed diff > below; patches contain broken out v4->v5 lists): > > - VirtioMmioDeviceLib.inf: drop UefiDriverEntryPoint library dependency > - VirtioFlush(): update comment block in VirtioLib.[hc]; error code is > propagated from VirtIo->SetQueueNotify(). > - typo fix in VirtioMmioInstallDevice() comment block > - add disclaimer (two instances) about the protocol being work in > progress > - ensure / document that the VIRTIO_BLK_DEVICE_PATH structure must be > packed > - fix whitespace damage in definition of "mVirtioBlockDevicePath" > - plug MmioDevice leak in VirtioMmioUninstallDevice() > - return EFI_INVALID_PARAMETER in VirtioMmioGetQueueAddress() if > QueueAddress is NULL > - VirtioMmioSetQueueSize(): fix return value (it's a status code) > - VirtioMmioSetPageSize(): check against EFI_PAGE_SIZE with "if" plus > EFI_UNSUPPORTED, rather than ASSERT() > - VirtioMmioDeviceWrite(), VirtioMmioDeviceRead(): remove redundant > (FieldSize > 8) checks > - VirtioBlkInit(): jump to Failed label if SetPageSize() fails > - VirtioBlkInit(): fixup comment, and add error handling, near > SetQueueNum() call > - VirtioBlkDriverBindingStart(): remove redundant (always false) check > for a subsystem device ID different from > VIRTIO_SUBSYSTEM_BLOCK_DEVICE; VirtioBlkDriverBindingSupported() > handles it already > - VirtioNetGetFeatures(): update stale comment block > - VirtioNetGetFeatures(): retrieve MAC address byte for byte (open-coded > loop) > - VirtioNetDriverBindingStart(): remove redundant (always false) check > for a subsystem device ID different from > VIRTIO_SUBSYSTEM_NETWORK_CARD; VirtioNetDriverBindingSupported() > handles it already > - VirtioNetInitRing(): call SetQueueNum() and SetQueueAlign() for proper > MMIO operation > - VirtioNetInitialize(): fix destination error label for when > SetPageSize() fails > - VirtioPciIoRead(): restore the original requirement that FieldSize > equal BufferSize exactly (not only divide it). The looping added in v4 > did not match the comment block, and the only place that used it in v4 > (ie. VirtioNetGetFeatures()) needs an open-coded loop anyway (will be > done in a later part of v5). > - updated comment block on VirtioPciDeviceRead() > - return EFI_UNSUPPORTED instead of failed ASSERT() in > VirtioPciSetPageSize() > - VirtioScsi.c: fix comment block of > VIRTIO_CFG_WRITE()/VIRTIO_CFG_READ() > - VirtioScsiInit(): fix destination error label for when SetPageSize() > fails > - VirtioScsiInit(): call SetQueueNum() and SetQueueAlign() for proper > MMIO operation > > Changes not visible in the squashed diff (because the end result is the > same in both v4 and v5): > > - ArmPlatformPkg/ArmVExpressPkg: Added the empty 'ArmFvpDxe' platform > UEFI driver: > - For uniformity, add the empty driver to > ArmVExpress-RTSM-AEMv8Ax4-foundation.* too in this patch, not just > ArmVExpress-RTSM-AEMv8Ax4.*. V4 added the empty driver to > ArmVExpress-RTSM-AEMv8Ax4-foundation.* not sooner than the next > patch, fusing it with other (= virtio) functionality. Let's split > these changes cleanly. > > - ArmPlatformPkg/ArmFvpDxe: Added Virtio Block support: > - the platform driver is added to all platform DSC and FDF files in > the previous patch; this patch focuses on virtio only
Ping :) Thanks Laszlo ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
