On 12/10/13 23:56, Jordan Justen wrote: > On Tue, Dec 10, 2013 at 1:54 PM, Laszlo Ersek <ler...@redhat.com> wrote: >> On 12/10/13 20:28, Jordan Justen wrote: >>> Laszlo, >>> >>> In comparing Olivier's v4 to your v5, I had some questions. >>> >>> Mainly, it seems like maybe some 'fixes' are sneaking into the commit >>> where we convert to using the protocol. >> >> Those fixes are not "sneaking". I requested them explicitly in my v4 >> review. My method for preparing version 5 was: >> - take Olivier's v4 >> - go through my review comments (and some of yours that I could find) on >> the list that have been posted for v4 >> - those comments pointed out problems in v4 >> - therefore I fixed those problems where they were introduced. >> >> Normally when a respin is done, if v(n) of a patch introduces a problem, >> then v(n+1) simply avoids introducing the problem. Followup patches are >> justified when: >> - v(n) has been committed, or >> - fixing problems in-place (ie. where v(n) introduces those problems) >> would be very hard / inconvenient (for example because it requires >> intrusive rebase in the rest of the series). >> >> None of this held for these changes. > > I guess my question was, could any of these changes be considered > necessary separate from this series? Or, are they all required > specifically because of the conversion to using the protocol?
Apologies for the long intro above... But, I did answer all your questions in the rest of your email individually. (I'm actually not 100% sure that you've seen my answers!) > > Your response above indicates they were issues introduced as part of > the conversion process, and yes, in that case they should be fixed in > the same commit in v5. Yes. And I hoped that my individual answers to your questions lower down were in support. > As such, I will move forward with the patches as is. (I still need to > review them a little more, and test VS builds.) Thanks! Laszlo ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
