On 02/08/14 00:17, Jordan Justen wrote: > From: Laszlo Ersek <ler...@redhat.com> > > The S3 suspend/resume infrastructure depends on the LockBox library class. > The edk2 tree currently contains Null and SMM instances. The Null instance > is useless, and the SMM instance would require SMM emulation by including > the SMM core and adding several new drivers, which is deemed too complex. > > Hence add a simple LockBoxLib instance for OVMF. > > jordan.l.jus...@intel.com: > * use PCDs instead of EmuNvramLib > - clear memory in PlatformPei on non S3 boots > * allocate NVS memory and store a pointer to that memory > - reduces memory use at fixed locations > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > OvmfPkg/Library/LockBoxLib/LockBoxBase.c | 42 +++ > OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf | 44 ++++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 62 +++++ > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 45 ++++ > OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 358 > ++++++++++++++++++++++++++ > OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 47 ++++ > OvmfPkg/OvmfPkg.dec | 2 + > OvmfPkg/OvmfPkgIa32.dsc | 3 +- > OvmfPkg/OvmfPkgIa32.fdf | 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 3 + > OvmfPkg/OvmfPkgX64.dsc | 3 +- > OvmfPkg/OvmfPkgX64.fdf | 3 + > OvmfPkg/PlatformPei/MemDetect.c | 17 ++ > OvmfPkg/PlatformPei/PlatformPei.inf | 2 + > 15 files changed, 634 insertions(+), 3 deletions(-) > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxBase.c > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxDxe.c > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxLib.c > create mode 100644 OvmfPkg/Library/LockBoxLib/LockBoxLib.h
This is (almost) identical to [PATCH v4 19/26] OvmfPkg: implement LockBoxLib I had a bunch of comments for that patch: http://thread.gmane.org/gmane.comp.bios.tianocore.devel/5789/focus=5876 but nothing seems to have changed in that regard. Did you disagree with my comments or did you miss them? Thanks, Laszlo ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
