On Mon, Feb 24, 2014 at 10:50 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/24/14 19:15, Jordan Justen wrote: >> From: Laszlo Ersek <ler...@redhat.com> >> >> The S3 suspend/resume infrastructure depends on the LockBox library class. >> The edk2 tree currently contains Null and SMM instances. The Null instance >> is useless, and the SMM instance would require SMM emulation by including >> the SMM core and adding several new drivers, which is deemed too complex. >> >> Hence add a simple LockBoxLib instance for OVMF. >> >> jordan.l.jus...@intel.com: >> * use PCDs instead of EmuNvramLib >> - clear memory in PlatformPei on non S3 boots >> * allocate NVS memory and store a pointer to that memory >> - reduces memory use at fixed locations >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >> Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> >> --- >> >> Laszlo, >> >> I think I took nearly all of your suggestions for v4 of this >> patch. (Which I missed for v5 of the series.) >> >> How does it look? Would you prefer me to bump the series >> to v6 to send this out in that context? > > No, this patch implements a library; the interface is nice and explicit. > Plus this is the only patch needing a respin, so I can review it the way > you posted it (you've set the in-reply-to correctly, so it's showed up > at the right spot in the series, in my edk2-devel folder). > > I'm adding it to my review queue.
Thanks. I meant to change the guid for LockBoxDxeLib.inf in this patch. It is now fixed on my ovmf-s3 branch. -Jordan ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
