Usage calls exit, so the return statements were never
used.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <[email protected]>
---
 Source/C/EfiLdrImage/EfiLdrImage.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/Source/C/EfiLdrImage/EfiLdrImage.c 
b/Source/C/EfiLdrImage/EfiLdrImage.c
index f83c532..cfc0521 100644
--- a/Source/C/EfiLdrImage/EfiLdrImage.c
+++ b/Source/C/EfiLdrImage/EfiLdrImage.c
@@ -89,11 +89,11 @@ Returns:
 
 VOID
 Usage (
-  VOID
+  int return_code
   )
 {
   printf ("Usage: EfiLdrImage -o OutImage LoaderImage PeImage1 PeImage2 ... 
PeImageN\n");
-  exit (1);
+  exit (return_code);
 }
 
 EFI_STATUS
@@ -188,16 +188,14 @@ Returns:
   SetUtilityName (UTILITY_NAME);
 
   if (argc == 1) {
-    Usage();
-    return STATUS_ERROR;
+    Usage(STATUS_ERROR);
   }
   
   argc --;
   argv ++;
 
   if ((stricmp (argv[0], "-h") == 0) || (stricmp (argv[0], "--help") == 0)) {
-    Usage();
-    return STATUS_SUCCESS;    
+    Usage(STATUS_SUCCESS);
   }
 
   if (stricmp (argv[0], "--version") == 0) {
-- 
1.9.2


------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to