On 05/21/14 10:19, Michael S. Tsirkin wrote: > On Wed, May 21, 2014 at 12:51:47AM +0200, Laszlo Ersek wrote: >> In one of the next patches we'll start scanning all fw_cfg files that QEMU >> advertises as carrying ACPI tables, not just "etc/acpi/tables". >> >> The RSD PTR table is known to occur in the "etc/acpi/rsdp" fw_cfg file. >> Since edk2 handles RSD PTR automatically, similarly to RSDT and XSDT, >> let's exclude RSD PTR too from the manually installed tables. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > Please don't rely on this name, there's a better way: > check the zone flag, anything that does not set it > to 0x1 is not an ACPI table. > In particular, RSDP is in ZONE_FSEG = 0x2. > > You can then safely ignore it without bothering parsing.
(Your messages reached edk2-devel after all!) - I don't use "etc/acpi/rsdp" in the source; the commit message mentions it as illustration. The patchset makes the OVMF code independent of individual "etc/acpi/*" names. - I noticed that the fw_cfg file containing the RSDP differs from the rest of the files in the Zone allocation hint, but I didn't want to directly associate that hint with the RSDP's presence. I'd prefer to leave the patchset as-is, unless Jordan insists that we should filter out the RSDP by looking at the Zone hint (rather than checking signatures in the payload). Thanks Laszlo ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
