Hi Tycho,
IoApicEnableInterrupt (mTimerIrq, TRUE) was wrongly removed at revision
12778, which caused HPET timer could not work when PcdHpetMsiEnable is set to
FALSE.
Thanks for finding this bug. I have verified the fix which worked well.
I am going to check in the fix.
Reviewed-by: Elvin Li <[email protected]>
Thanks
Elvin
-----Original Message-----
From: Tycho Nightingale [mailto:[email protected]]
Sent: Friday, June 20, 2014 4:13 AM
To: [email protected]
Subject: [edk2] [PATCH] PcAtChipsetPkg: Enable timer interrupt through I/O APIC
Hi,
Please review the following patch which brings the code inline with the
preceding comment and actually performs the enable of the HPET timer interrupt
through the I/O APIC.
Thanks.
Tycho
PcAtChipsetPkg: Enable timer interrupt through I/O APIC
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tycho Nightingale <[email protected]>
diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c b/PcAtChipsetPkg/HpetTimerD
index b9bf080..142308c 100644
--- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c
+++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c
@@ -594,6 +594,7 @@ TimerDriverSetTimerPeriod (
// Program IOAPIC register with APIC ID of current BSP in case BSP has be
//
IoApicConfigureInterrupt (mTimerIrq, PcdGet8 (PcdHpetLocalApicVector), IO
+ IoApicEnableInterrupt (mTimerIrq, TRUE);
}
//
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
