On 06/24/14 13:50, Paolo Bonzini wrote: > Il 24/06/2014 13:33, Laszlo Ersek ha scritto: >> The code being removed checks if "./BaseTools/BuildEnv" is the same >> script file (by device and inode numbers) as the one executing (whether >> forked or sourced). This seems to be the polar opposite of what >> EDK_TOOLS_PATH is supposed to enable -- an out-of-WORKSPACE (== $PWD) >> BaseTools subdir. I checked the commit log but still can't figure out >> why this check was added in the first place. >> >> If the SetWorkspace function only wants to ensure that it is called from >> the root of an edk2 clone (ie. a WORKSPACE candidate), then it should >> check eg. for the existence of "./MdePkg/MdePkg.dec", rather than >> depending on an embedded BaseTools (which defeats EDK_TOOLS_PATH). > > I agree that having a check like this makes a lot of sense. However, > BaseTools should not have dependencies on the layout of EDK2, I think. > Perhaps this check should be in edksetup.sh's SetupEnv rather than > BaseTools/BuildEnv?
Good point. Laszlo ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
