On 06/24/14 11:55, Paolo Bonzini wrote: > As long as $EDK_TOOLS_PATH is properly set, the BaseTools/ directory > is not necessary in the workspace. The BuildEnv file itself suggests > setting the variable if BaseTools/ is not available. > > However, this only works if the user also sets $WORKSPACE. Otherwise, > BuildEnv refuses to set WORKSPACE itself and does not even try to use > the preset $EDK_TOOLS_PATH. Remove the check that fails, as it does > not have any practical benefit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paolo Bonzini <[email protected]> > > --- a/BaseTools/BuildEnv > +++ b/BaseTools/BuildEnv > @@ -23,14 +23,6 @@ > return 0 > fi > > - if [ ! ${BASH_SOURCE[0]} -ef ./BaseTools/BuildEnv ] > - then > - echo Run this script from the base of your tree. For example: > - echo " cd /Path/To/Edk/Root" > - echo " . BaseTools/BuildEnv" > - return 1 > - fi > - > # > # Set $WORKSPACE > # >
Given Paolo's [PATCH v2 0/2] edksetup.sh: Improvements for out-of-tree BaseTools Reviewed-by: Laszlo Ersek <[email protected]> ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
