Jordan, the "index.php" part of the wiki address has some problem recently. Say, instead of http://tianocore.sourceforge.net/wiki/index.php/EDK_II_git-svn we may use http://tianocore.sourceforge.net/wiki/EDK_II_git-svn Thanks, Plamen -----Original Message----- From: Jordan Justen [mailto:[email protected]] Sent: Tuesday, June 24, 2014 12:24 PM To: Gao, Liming Cc: [email protected] Subject: Re: [edk2] [PATCH] Fix GCC44 build failure in OVMF platform
On Tue, Jun 24, 2014 at 12:29 AM, Gao, Liming <[email protected]> wrote: > When I use GCC build OVMF IA32 platform, the error that ‘FwhInstance’ may > be used uninitialized in function ‘FvbSetVolumeAttributes’ will be reported > in OvmfPkg/QemuFlashFvbServicesRuntimeDxe. This patch fixes it. Please help > review it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gao, Liming <[email protected]> The code looks good, but I'd like to see a full commit message before saying reviewed-by: http://tianocore.sourceforge.net/wiki/index.php/Code_Style/Commit_Message (I hope the new wiki is working! :) Using git with git format-patch + send-email puts the commit message and patch into a nicely formatted email for the list. It is also a bit easier to code review by just replying directly to the patch contents. So long as we're stuck using svn, you might find info on this page helpful for using git-svn with EDK II: http://tianocore.sourceforge.net/wiki/index.php/EDK_II_git-svn -Jordan ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
