On 06/25/14 05:49, Jordan Justen wrote: > The git command 'git am' will take an email message (or git patch > attached to an email), and apply the patch along with the commit > message making it very easy for the patch submitter to send the patch > along with a good commit message, and also making it very easy for the > maintainer to incorporate that patch into the tree.
Right. There's one quirk for edk2: since the project uses CRLF line terminators, one needs git config core.whitespace cr-at-eol git config am.keepcr true (The 2nd command is important for 'git am'.) > Laszlo, > > Your 0004 patch is Reviewed-by: Jordan Justen > <[email protected]>, and committed. Thanks! > I think it is usually > better to use git send-email with patches, rather than attaching them > because they are more easy to notice and to code review. In the general case I agree (and I don't disagree in this case either). In an ongoing discussion, when I *reply* with patches, I'm torn between attaching the patches or just sending them with In-Reply-To. For example, AFAICT, qemu-devel doesn't like patches posted in-thread, so you're bound to lose either the threading or the plaintext patch posting. Also in the past I think I've experienced less abuse to (non-OvmfPkg, non-Arm*Pkg) commit messages on edk2-devel when patches were attached. I had no specific worry in this case, it was just a fuzzy feeling that attaching the patches would be safer for threading (albeit harder to notice / review). I'll mail them directly next time, with In-Reply-To. It's great that the commit message details have been discussed in advance this time! Thanks Laszlo ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
