Olivier,

The patch is good to me.
Reviewed-by: Yingke Liu <yingke.d....@intel.com<mailto:yingke.d....@intel.com>>

Thanks,

Dennis

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Saturday, August 02, 2014 2:22 AM
To: edk2-devel@lists.sourceforge.net; Wang, Yu
Cc: Harry Liebel
Subject: Re: [edk2] [PATCH] BaseTools: Add AArch64 ADR_PREL_LO21 and 
R_AARCH64_CONDBR19 relocations

Dear BaseTools maintainer,
Could you review and/or commit this patch to BaseTools? I did not have any 
feedback in the last 4 weeks.
Thanks,
Olivier

From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 07 July 2014 16:35
To: 
edk2-buildtools-de...@lists.sourceforge.net<mailto:edk2-buildtools-de...@lists.sourceforge.net>
Cc: Harry Liebel
Subject: [PATCH] BaseTools: Add AArch64 ADR_PREL_LO21 and R_AARCH64_CONDBR19 
relocations

Dear BaseTools maintainers,

Please find the attached patch that adds support for these two AArch64 
relocations:
- ADR_PREL_LO21: support for loading a PC relative label offset.
- R_AARCH64_CONDBR19: support for conditional branch instruction (ELF64 code: 
280).

If none of the maintainers disagrees, I will push this patch into the BaseTools 
repository as it only affects common code and non-AArch64 code.
I will wait until the end of next week for any feedback.

Contributed-under: Tianocore Contribution Agreement 1.0
Signed-off-by: Harry Liebel <harry.lie...@arm.com<mailto:harry.lie...@arm.com>>
Signed-off-by: Olivier Martin 
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>>

Thanks,
Olivier
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to