ShellPkg\Application\Shell\ShellProtocol.c
Return values description for function EfiShellGetEnvEx()
New comment uses @return to describe the non-NULL return case and says it
returns the variable's value. If you are going to use an @return, I think you
should indicate that "A non-NULL value points to the variable's value".
Otherwise, a construct like the original "@retval !=NULL yada-yada-yada" may
be better.
Return values description for function EfiShellGetEnv()
Invalid Doxygen tag use: "@return !=NULL yada-yada-yada". Just change
"@return" to "@retval" and all is fine.
Once these issues are addressed, I think the patch is fine.
So, provisionally:
Reviewed by: Daryl McDaniel <[email protected]>
Daryl McDaniel
"It is the mark of an educated mind to be able to entertain a thought without
accepting it."
- Aristotle
From: Carsey, Jaben
Sent: Tuesday, August 05, 2014 3:01 PM
To: Bjorge, Erik C; Rosenbaum, Lee G; Mcdaniel, Daryl; Cohen, Eugene; Phillips,
Chris J (BCS CFE) ([email protected])
Cc: [email protected]; Carsey, Jaben
Subject: ShellPkg: Update Shell for UEFI Shell 2.1 changes
Erik, Lee, Eugene, Chris, or Daryl,
Can you verify this patch?
Updates the UEFI Shell to produce the new protocol with additional 4 functions.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
