Hi Folks, I agree that we should modify the svn property although it still does not fix the issue with code reviews for the files. I have attached the proposed patch; please review and let me know if there are any issues.
Change svn:mime-type property on all Unicode files (extension .uni) in edk2 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lhauch <larry.ha...@intel.com> Cheers, Larry -----Original Message----- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Thursday, August 14, 2014 8:06 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages It is not a problem for this patch (since the new UNI files are in the ZIP). I agree that with UTF16 file types, the patch file itself is not very readable. But at least I can take a patch file (from this email list for instance), and apply it using SVN to my tree, and it will automatically apply the string changes to UNI files. I can also generate patch files from my tree that include UNI file changes and send them to this list to review This is definitely better than binary files that cannot be dealt with AT ALL using SVN diff In order to achieve this, we need to change ALL UNI files in EDK2 from: svn:mime-type = application/octect-stream To: svn:mime-type = text/plain;encoding=UTF-16LE Can someone please help with this change? -----Original Message----- From: Gao, Liming [mailto:liming....@intel.com] Sent: Wednesday, August 13, 2014 9:36 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages Yes. This is a possible solution. But, svn generated patch for UTF16 file is not good readability. This patch adds new UNI files. You can see them from ZIP files. Thanks Liming -----Original Message----- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Thursday, August 14, 2014 10:26 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages Can we change the file encoding type svn property for uni files to make them utf16 instead of binary stream? This way we can actually include uni files in patches and see what changed. -----Original Message----- From: Gao, Liming [liming....@intel.com] Received: Wednesday, 13 Aug 2014, 9:17PM To: edk2-devel@lists.sourceforge.net [edk2-devel@lists.sourceforge.net] Subject: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages Hi, all Could you help review this patch? It includes the following changes 1-6 for MdePkg. The patch is a little big. For new added UNI file, I zip them together. The second patch for below item 7 will be sent later Thanks Liming From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, August 07, 2014 5:32 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] INF/DEC file updates to EDK II packages Hello, I wanted to let everyone know about a number of patch reviews for EDK II packages that will be sent out over the next couple of weeks. These patches impact the order of content in INF/DEC files and comment blocks in INF/DEC files, and should not have any build or functionality impacts. These patches will address the following issues: 1) Usage information in INF file comment blocks are either incomplete or incorrect. This includes usage information for Protocols/PPIs/GUIDs/PCDs/HOBs/Events/BootModes. The syntax for usage information in comment blocks is defined in the EDK II Module Information (INF) Specification 2) Add MODULE_UNI_FILE to INF [Defines] section along with UNI file that contains the localized Abstract and Description of a module. a. Addresses an information gap between INF files and the UEFI Distribution Packaging Specification XML schema b. There will be an associated update to UPT in BaseTools to consume MODULE_UNI_FILE and associated UNI file during UDP creation that performs the INF -> XML conversion. c. There will be an associated update to UPT in BaseTools to produce MODULE_UNI_FILE and associated UNI file during UDP installation that performs the XML -> INF conversion. 3) Add [UserExtensions.TianoCore."ExtraFiles"] section to INF files along with associated UNI file that provides the localized Name of a module. a. [UserExtensions.TianoCore."ExtraFiles"] provides an easy method for a module to specify extra files not listed in [Sources] or [Binaries] sections to be added to a UDP without having to list the files in the UPT package information data file. b. There will be an associated update to UPT in BaseTools to package up files listed in [UserExtensions.TianoCore."ExtraFiles"] during UDP creation. c. UNI file contains localized name of a module to go along with the localized Abstract and Description from the MODULE_UNI_FILE. 4) PCD information in DEC file comment blocks are either incomplete or incorrect. This includes detailed description, @Prompt, @ValidRange, @ValidList, @Expression, and [Error.<TokenSpaceGuid>] validation error messages 5) Add PACKAGE_UNI_FILE to DEC [Defines] section along with UNI file that contains the localized Abstract and Description of a package and localized strings associated with PCDs. a. Addresses an information gap between DEC files and the UEFI Distribution Packaging Specification XML schema b. There will be an associated update to UPT in BaseTools to consume PACKAGE_UNI_FILE and associated UNI file during UDP creation that performs the DEC -> XML conversion. c. There will be an associated update to UPT in BaseTools to produce PACKAGE_UNI_FILE and associated UNI file during UDP installation that performs the XML -> DEC conversion. 6) Add [UserExtensions.TianoCore."ExtraFiles"] section to DEC files along with associated UNI file that provides the localized Name of a package. a. [UserExtensions.TianoCore."ExtraFiles"] provides an easy method for a package to specify extra files to be added to a UDP without having to list the files in the UPT package information data file. b. There will be an associated update to UPT in BaseTools to package up files listed in [UserExtensions.TianoCore."ExtraFiles"] during UDP creation. c. UNI file contains localized name of a package to go along with the localized Abstract and Description from the PACKAGE_UNI_FILE. 7) Make sure order of DEC/INF content matches the order that UPT generates in the XML -> INF conversion a. This allows UDP packages installed by UPT to be compared against EDK II trunk/branches using standard diff utilities. Patches for the following EDK II packages are being prepared 1) MdePkg 2) MdeModulePkg 3) IntelFrameworkPkg 4) IntelFrameworkModulePkg 5) FatPkg 6) ShellPkg 7) PcAtChipsetPkg 8) UefiCpuPkg 9) SourceLevelDebugPkg 10) CryptoPkg 11) SecurityPkg 12) NetworkPkg Best regards, Mike ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
UnicodeFileProperty.patch
Description: UnicodeFileProperty.patch
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
