Laszlo: FeaturePcd must use FeaturePcdGet() API to get its value. So, it is a good style to place it into [FeaturePcd] section. Those PCD in [Pcd] section uses PcdGetXXX() to get its value.
Thanks Liming -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 15, 2014 2:53 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH v3 2/3] MdePkg: introduce BaseOrderedCollectionRedBlackTreeLib library instance On 08/15/14 08:22, Gao, Liming wrote: > Hi, > I just find one minor issue. PcdValidateOrderedCollection is > PcdsFeatureFlag. It should be listed in [FeaturePcd] instead of [Pcd] section > in INF file. > > +[Pcd] > + gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedCollection ## CONSUMES Thank you for the feedback! Is this a strict requirement though? I modeled "PcdValidateOrderedCollection" after "PcdVerifyNodeInList", which is also declared under [PcdsFeatureFlag] in "MdePkg/MdePkg.dec". And, if you search for INF files referencing "PcdVerifyNodeInList", you can find: MdePkg/Library/BaseLib/BaseLib.inf: [Pcd] gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList <------ here That is, the model for "PcdValidateOrderedCollection", "PcdVerifyNodeInList", is also used by INF file(s) in their plain [Pcd] section(s). (See SVN r9016.) Thanks, Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
