Please review and provide any feedback.


This code change removes EFI_SHELL_PROTOCOL21 and instead includes the new 
structure members from UEFI Shell 2.1 spec (RegisterGuidName, GetGuidName, 
GetGuidFromName, and GetEnvEx) into EFI_SHELL_PROTOCOL.



A comment note was added to explain that ShellProtocol MajorVersion and 
MinorVersion must be checked before attempting to use the new members (version 
check not needed when using a UEFI Shell 2.0 spec member).  This is for the 
case that a new UEFI Shell 2.1 application might be running on an older UEFI 
Shell 2.0 shell.



Any UEFI Shell 2.0 applications will be backward supported with the new 
EFI_SHELL_PROTOCOL, since new members will not be used.  I tested with a couple 
pre-built shell applications we have that use the ShellProtocol to perform 
different tasks.  No issues found.



Thanks,

Chris





ShellPkg: Fix EFI_SHELL_PROTOCOL to contain new members from UEFI Shell 2.1 spec

- Removes EFI_SHELL_PROTOCOL21

- Adds RegisterGuidName, GetGuidName, GetGuidFromName, and GetEnvEx to 
EFI_SHELL_PROTOCOL



Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Chris Phillips <[email protected]<mailto:[email protected]>>

Attachment: UefiShell21Fixes.patch
Description: UefiShell21Fixes.patch

------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to