Yes that’s right. I have just waste another couple of hours with this buggy “!if” support.
From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: 19 August 2014 18:57 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch][Basetools]Fix a build failure in Linux Because if statement is always FALSE. On 19 авг. 2014 г., at 19:49, Olivier Martin <olivier.mar...@arm.com> wrote: I confirm this error too. It looks the recent BaseTools requires a ‘!else’ to interpret the file correctly ... From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: 19 August 2014 12:44 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch][Basetools]Fix a build failure in Linux Sorry, it was with old build.py. With all new files all works but as I see the syntax of fdf files become more strict Previously I have ---------- !if ($(ARCH) == X64) [FV.DuetEfiMainFvX64] !elseif ($(ARCH) == IA32) [FV.DuetEfiMainFvIA32] !endif ---------- now this is a syntax error -------- warning: Suspicious expression: == Comparison between Operand of string type and Boolean/Number Type always return False. !if ($(ARCH) == X64) --------- When I use -------- !if ("$(ARCH)" == "X64") -------- This is good but error at !endif Then I add Else section --------------- !if ("$(ARCH)" == "X64") [FV.DuetEfiMainFvX64] !elseif ("$(ARCH)" == "IA32") [FV.DuetEfiMainFvIA32] !else [FV.DuetEfiMainFvX64] !endif --------------- and got successful compilation... but a result is questionable. How to do it right way? On 19.08.2014, at 13:14, Gao, Liming wrote: Could you show the error message? From: Sergey Isakov [ <mailto:isakov...@bk.ru> mailto:isakov...@bk.ru] Sent: Tuesday, August 19, 2014 5:05 PM To: <mailto:edk2-devel@lists.sourceforge.net> edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch][Basetools]Fix a build failure in Linux No, revision 15831 is still not working in OSX. On 19.08.2014, at 12:07, Gao, Liming wrote: Hess: The patch is good. Reviewed-by: Gao, Liming < <mailto:liming....@intel.com> liming....@intel.com> From: Chen, Hesheng [ <mailto:hesheng.c...@intel.com> mailto:hesheng.c...@intel.com] Sent: Tuesday, August 19, 2014 2:44 PM To: <mailto:edk2-devel@lists.sourceforge.net> edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch][Basetools]Fix a build failure in Linux Hello all, Could you help review this patch? This patch is going to fix a build failure in Linux system. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen < <mailto:hesheng.c...@intel.com> hesheng.c...@intel.com> Best Regards, Chen, Hess Intel China Software Center Tel: +86-21-6116-6740 Email: <mailto:hesheng.c...@intel.com> hesheng.c...@intel.com ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list <mailto:edk2-devel@lists.sourceforge.net> edk2-devel@lists.sourceforge.net <https://lists.sourceforge.net/lists/listinfo/edk2-devel> https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list <mailto:edk2-devel@lists.sourceforge.net> edk2-devel@lists.sourceforge.net <https://lists.sourceforge.net/lists/listinfo/edk2-devel> https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
