Daryl, On 08/20/14 19:42, Olivier Martin wrote: > That’s exactly the patch I sent in 2002. So I could only be ok with my > changes. > > If replacing my name by yours in the “signed-off-by” can make this > change merged as quick as possible then I am happy to add “Reviewed-By: > Olivier Martin <olivier.mar...@arm.com>”. > > *From:*Mcdaniel, Daryl [mailto:daryl.mcdan...@intel.com] > *Sent:* 20 August 2014 18:18 > *To:* edk2-devel@lists.sourceforge.net > *Cc:* Olivier Martin; ler...@redhat.com > *Subject:* Patch for review: vfscanf > > Laszlo or Olivier, could you please review the attached patch. > > I’ve tested this with several versions of GCC, VC++, Intel Compiler > (ICC) on Fedora, Ubuntu, and Windows 7 hosts. > > NOTE! There remains a problem with long double and GCC . It is not > related to this patch, though. > > I am releasing this patch to address “StdLib: the long > standing build error”, reported by Olivier in June 2012. > > -------- > > StdLib: reinstate the use of va_arg() to handle long double arguments in > vfscanf. > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Daryl McDaniel <daryl.mcdan...@intel.com > <mailto:daryl.mcdan...@intel.com>>
I'm OK with the patch. I'll let you guys figure out how the S-o-b and R-b should look like. But I have a side question: has something changed in the VS landscape? Doesn't this patch trip up some of the supported Microsoft compilers? I'm just curious. (Of course I agree that as long as this patch works with all supported compilers, then it's the ideal one.) Thanks! Laszlo ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
