I see the same offset issue. It should be +1 instead of +2.
If you use +2, it will cause parser to add one extra character beyond ending
quote.
Example:
Shell>echo "TESTING""EXECUTE"
"TESTING"" "EXECUTE" <------- it took extra " in 1st parameter.
Reviewed-by: Tapan Shah <[email protected]<mailto:[email protected]>>
Thanks,
Tapan
From: Bjorge, Erik C [mailto:[email protected]]
Sent: Thursday, August 21, 2014 5:06 PM
To: Carsey, Jaben; Shah, Tapan
Cc: [email protected]; Lohr, Paul A; El-Haj-Mahmoud, Samer;
Phillips, Chris J (Plano, TX)
Subject: RE: ShellPkg: leave quotes around params
I think you have an off by one error. Should be +1 instead of +2. Please test
to make sure I am not insane. Otherwise I am fine with the change.
Reviewed-by: Erik Bjorge
<[email protected]<mailto:[email protected]>>
Thanks,
-Erik
From: Carsey, Jaben
Sent: Thursday, August 21, 2014 1:42 PM
To: Bjorge, Erik C; Shah, Tapan ([email protected]<mailto:[email protected]>)
Cc: [email protected]<mailto:[email protected]>;
Lohr, Paul A; El-Haj-Mahmoud, Samer
([email protected]<mailto:[email protected]>); Phillips,
Chris J (BCS CFE) ([email protected]<mailto:[email protected]>); Carsey, Jaben
Subject: ShellPkg: leave quotes around params
Erik or Tapan,
Can you review this patch?
This makes sure that quotes are left around parameters when they are passed to
commands or apps so prevent them from being interpreted as a flag.
ShellPkg: leave quotes around params
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
