On 25 August 2014 22:03, Laszlo Ersek <ler...@redhat.com> wrote: > On 08/25/14 21:19, Ard Biesheuvel wrote: >> This series adds a platform config to support QEMU based virtual machines, >> either in TCG or KVM mode. These virtual machines declare their platform >> configuration by passing a device tree which needs to be parsed by Tianocore >> rather than relying on hardcoded peripherals. >> >> Currently, the only assumptions made with respect to the platform config are: >> - at least 1 MB of DRAM at 0x4000_0000 >> - NOR flash at 0x0 > > I'll strive to find the time to review this great series. > > But, in advance, can we put the flash somewhere else, like at 0x8 or > 0x10? Every time we treat NULL as a valid pointer to a firmware volume > *in C*, the fabric of the universe comes a bit more unstitched.
You *must* have the flash at zero, because zero is the reset address. UEFI is firmware, and it needs to expect to be at zero. This is exactly where hardware puts flash for boot roms, so you already have (or have solved) this issue for the versatile express ports. It looks like Ard has a fix that avoids the C parts of UEFI needing to refer to address 0 directly, but the flash is still at zero and it can't move... thanks -- PMM ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
