The change is good to me. Reviewed-by: Gao, Liming <[email protected]>
-----Original Message----- From: Andrew Fish [mailto:[email protected]] Sent: Wednesday, August 27, 2014 7:37 AM To: [email protected] Subject: [edk2] [BaseTools] [PATCH 2/5] clang warns that since BaseAddress is unsigned it can never be < 0. clang warns that since BaseAddress is unsigned it can never be < 0. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anderw Fish <[email protected]> --- BaseTools/Source/C/GenVtf/GenVtf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c b/BaseTools/Source/C/GenVtf/GenVtf.c index 60df349..256a2b1 100644 --- a/BaseTools/Source/C/GenVtf/GenVtf.c +++ b/BaseTools/Source/C/GenVtf/GenVtf.c @@ -1722,7 +1722,7 @@ Returns: --*/ { - if ((BaseAddress >= 0) && (FwVolSize > 0x40) && ((BaseAddress + FwVolSize) % 8 == 0)) { + if ((FwVolSize > 0x40) && ((BaseAddress + FwVolSize) % 8 == 0)) { return EFI_SUCCESS; } -- 1.8.5.2 (Apple Git-48) ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
