Reviewed-by: Eric Dong <[email protected]> -----Original Message----- From: Andrew Fish [mailto:[email protected]] Sent: Wednesday, August 27, 2014 7:37 AM To: [email protected] Subject: [edk2] [BaseTools][PATCH 5/5] BaseTools: Fix clang C++ build error.
Fix clang C++ build error. Move argument default to constructor to remove clang warning. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anderw Fish <[email protected]> --- BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 2 +- BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp index 6dfc118..376a454 100644 --- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp +++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp @@ -95,7 +95,7 @@ SPendingAssign::GetKey ( } CFormPkg::CFormPkg ( - IN UINT32 BufferSize = 4096 + IN UINT32 BufferSize ) { CHAR8 *BufferStart; diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.h b/BaseTools/Source/C/VfrCompile/VfrFormPkg.h index 17471e6..3d2def8 100644 --- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.h +++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.h @@ -124,7 +124,7 @@ private: SPendingAssign *PendingAssignList; public: - CFormPkg (IN UINT32 BufferSize); + CFormPkg (IN UINT32 BufferSize = 4096); ~CFormPkg (); CHAR8 * IfrBinBufferGet (IN UINT32); -- 1.8.5.2 (Apple Git-48) ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
