Hi Alexei,

Thanks for your finding, attach the patch for your review.

MdePkg Acpi51.h: Correct the declaration of 
EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE.


Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Star Zeng <[email protected]<mailto:[email protected]>>

Thanks,
Star
From: Alexei Fedorov [mailto:[email protected]]
Sent: Wednesday, August 27, 2014 9:35 PM
To: [email protected]
Subject: [edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE


EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE declaration in 
\edk2\MdePkg\Include\IndustryStandard\Acpi51.h has wrong field lengths:



///

/// SBSA Generic Watchdog Structure

///

typedef struct {

  UINT8   Type;

  UINT8   Length;

  UINT16  Reserved;

...



This should be



typedef struct {

  UINT8   Type;

  UINT16  Length;

  UINT8   Reserved;

...



According to Table 5-123 SBSA Generic Watchdog Structure Format of ACPI 5.1 
Specification on p.197:



Field    Byte Length Byte Offset Description

Type     1           0           0x1 Watchdog GT

Length   2           1           28

Reserved 1           3           Must be zero



Alexei.



-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No: 2548782

Attachment: Acpi51.h.patch
Description: Acpi51.h.patch

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to