On 08/27/14 17:12, Ard Biesheuvel wrote: > diff --git > a/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.c > > b/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.c > new file mode 100644 > index 000000000000..514d9358964c > --- /dev/null > +++ > b/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.c > @@ -0,0 +1,95 @@ > +/** @file AArch64VirtualizationSysConfigLibKVM.c > + > + Copyright (c) 2011-2012, ARM Ltd. All rights reserved.<BR> > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD > License > + which accompanies this distribution. The full text of the license may be > found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +**/ > + > +#include <Base.h> > +#include <Library/IoLib.h> > +#include <Library/DebugLib.h> > + > +#include <Library/ArmPlatformSysConfigLib.h> > +#include <ArmPlatform.h> > + > + > +/**************************************************************************** > + * > + * Stub for KVM at the moment > + * > + > ****************************************************************************/ > + > +RETURN_STATUS > +ArmPlatformSysConfigInitialize ( > + VOID > + ) > +{ > + return RETURN_SUCCESS; > +} > + > +/*************************************** > + * GENERAL FUNCTION: AccessSysCfgRegister > + * Interacts with > + * SYS_CFGSTAT > + * SYS_CFGDATA > + * SYS_CFGCTRL > + * for setting and for reading out values > + ***************************************/ > + > +RETURN_STATUS > +AccessSysCfgRegister ( > + IN UINT32 ReadWrite, > + IN UINT32 Function, > + IN UINT32 Site, > + IN UINT32 Position, > + IN UINT32 Device, > + IN OUT UINT32* Data > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmPlatformSysConfigGet ( > + IN SYS_CONFIG_FUNCTION Function, > + OUT UINT32* Value > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmPlatformSysConfigGetValues ( > + IN SYS_CONFIG_FUNCTION Function, > + IN UINTN Size, > + OUT UINT32* Values > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmPlatformSysConfigSet ( > + IN SYS_CONFIG_FUNCTION Function, > + IN UINT32 Value > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmPlatformSysConfigSetDevice ( > + IN SYS_CONFIG_FUNCTION Function, > + IN UINT32 Device, > + IN UINT32 Value > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > diff --git > a/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.inf > > b/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.inf > new file mode 100644 > index 000000000000..d4a495147de5 > --- /dev/null > +++ > b/ArmPlatformPkg/AArch64VirtualizationPkg/Library/AArch64VirtualizationSysConfigLibKVM/AArch64VirtualizationSysConfigLibKVM.inf > @@ -0,0 +1,35 @@ > +#/** @file > +# > +# Component description file for AArch64VirtualizationSysConfigLib module
AArch64 reference > +# > +# Copyright (c) 2011-2012, ARM Ltd. All rights reserved.<BR> > +# Copyright (c) 2014, > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD > License > +# which accompanies this distribution. The full text of the license may be > found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = AArch64VirtualizationSysConfigLibKVM base name should preferably end with Lib, *and* match the basename of the containing directory > + FILE_GUID = b5988e68-a2cc-49ac-9ca8-8cc78420ae45 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = ArmPlatformSysConfigLib > + > +[Sources.common] > + AArch64VirtualizationSysConfigLibKVM.c > + > +[Packages] > + MdePkg/MdePkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > + > +[LibraryClasses] > + BaseLib > + IoLib When you split this out into a separate patch, you can add my Acked-by: Laszlo Ersek <[email protected]> to it. This module is a no-op library instance, basically. It's also correctly used to resolve the library class in the DSC. It would be nice to clean up BASE_NAME etc, but I don't want to drive you mad. :) Can be done incrementally later, if anyone cares. Thanks, Laszlo ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
