Hi Samer,

I would like more information from you about your proposal.

The rules in the EDK II FDF/DSC and Build Specs say that Macros must be defined 
in either the DSC or FDF files before they can be used.
Are you requesting a change to this behavior or are you requesting the ability 
to set these macros in DSC/FDF files?

If you expect to set these values using DEFINE statements, then for things like 
the "${s_path}" macro that is currently used by tools to be an absolute path, 
additional work would have to be done by tools to prevent DEFINE statements 
setting this value outside of the current workspace.

These macros, while defined in the build_rule.txt file, are for internal tool 
implementation and they may be changed or deleted at any time.
We did not want to confuse the platform/module developers with constructs that 
are specific to the tools; that is why the definitions were remove from Build 
Spec.

Also, please provide some direction on the specification changes required to 
support your proposals (FDF and Build specs, and the DSC spec if you plan on 
setting these macros in that file).
I know we would have to modify the Macros EBNF definitions as well, since these 
use characters that are not currently allowed.
What other sections would need modifications and would there be other 
restrictions that would have to be put on their usage?

I short example of their usage would also be helpful.

Cheers,
Larry


From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 6:35 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros 
in FDF files

Thanks Yingke. Please let me know if you have any questions.

Thanks,
--Samer


From: Liu, Yingke D [mailto:yingke.d....@intel.com]
Sent: Monday, August 25, 2014 11:49 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros 
in FDF files

Hi Samer,

Thanks for this patch, it's really a good new feature, we will evaluate this 
feature and let you know the feedback later.

Thanks,
Dennis

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 4:59 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros in 
FDF files

Dear BaseTools maintainers,

Please see attached patch to:

Add support for ${s_*} and ${d_*} macros for in FDF file for the INF files, and 
for each statement in the build rules.
The following keywords are supported:
"src", "s_path", "s_dir", "s_name", "s_base", "s_ext", "dst", "d_path", 
"d_name", "d_base", "d_ext"


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud el...@hp.com<mailto:el...@hp.com>



Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers

el...@hp.com<mailto:el...@hp.com>
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>

[Description: Description: C:\Users\elhajmah\HpLogo.png]

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to