On 08/28/14 16:13, Ard Biesheuvel wrote:
> This include file contains platform specific defines, and is shared by
> various modules.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Acked-by: Laszlo Ersek <[email protected]>
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
>  .../ArmVirtualizationPkg/Include/ArmPlatform.h     | 33 
> ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 ArmPlatformPkg/ArmVirtualizationPkg/Include/ArmPlatform.h
> 
> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/Include/ArmPlatform.h 
> b/ArmPlatformPkg/ArmVirtualizationPkg/Include/ArmPlatform.h
> new file mode 100644
> index 000000000000..10936ec41143
> --- /dev/null
> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/Include/ArmPlatform.h
> @@ -0,0 +1,33 @@
> +/** @file
> +*  Header defining platform constants (Base addresses, sizes, flags)
> +*
> +*  Copyright (c) 2011, ARM Limited. All rights reserved.
> +*  Copyright (c) 2014, Linaro Limited
> +*
> +*  This program and the accompanying materials
> +*  are licensed and made available under the terms and conditions of the BSD 
> License
> +*  which accompanies this distribution.  The full text of the license may be 
> found at
> +*  http://opensource.org/licenses/bsd-license.php
> +*
> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
> IMPLIED.
> +*
> +**/
> +
> +#ifndef __ARM_VIRT_H__
> +#define __ARM_VIRT_H__
> +
> +//
> +// We don't care about this value, but the PL031 driver depends on the macro
> +// to exist: it will pass it on to our ArmPlatformSysConfigLib:ConfigGet()
> +// function, which just returns EFI_UNSUPPORTED.
> +//
> +#define SYS_CFG_RTC       0x0
> +
> +#define QEMU_NOR_BSIZE    SIZE_256KB
> +#define QEMU_NOR0_BASE    0x0
> +#define QEMU_NOR0_SIZE    SIZE_64MB
> +#define QEMU_NOR1_BASE    0x04000000
> +#define QEMU_NOR1_SIZE    SIZE_64MB
> +
> +#endif
> 

Good job updating the comment style, KVM->(VIRT|platform), and adding
the other macros. My ACK stands.

Thanks,
Laszlo

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to