On Fri, Aug 29, 2014 at 2:22 PM, Andrew Fish <[email protected]> wrote:
> On Aug 29, 2014, at 2:10 PM, Carsey, Jaben <[email protected]> wrote:
>> I think it’s a result of cut and paste via Microsoft office.  When I look in
>> the SVN repo via Tortoise SVN they look ok.
>
> I thought these mails are coming from a commit hook on the svn server? Since
> it is automated, it seems like it could be fixed?

I spent some time looking at this a while back.

We are sending --encoding UTF-8 to svnnotify, yet it still comes out
garbled. I suspect that the process that add the sourceforge
advertising might be part of the problem.

I tweaked some of the svnnotify settings just now, and they took
effect. Therefore, I think --encoding UTF-8 is actually on the command
line, yet it is not helping.

According to our long standing commit message format:
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
"The entire log message should use only standard ASCII text characters"

So, really these commit messages are at fault.

Not that this format gets adhered to all that consistently... :\

-Jordan

> From: Andrew Fish [mailto:[email protected]]
> Sent: Friday, August 29, 2014 2:07 PM
> To: [email protected]
> Cc: [email protected]
> Subject: Re: SF.net SVN: edk2:[15984]
> trunk/edk2/ShellPkg/Library/UefiDpLib/UefiDpLib. uni
>
>
> On Aug 29, 2014, at 1:02 PM, [email protected] wrote:
>
>
> Revision: 15984
>          http://sourceforge.net/p/edk2/code/15984
> Author:   jcarsey
> Date:     2014-08-29 20:02:38 +0000 (Fri, 29 Aug 2014)
> Log Message:
> -----------
> Cleanup UefiDpLib ?\226?\128?\152dp?\226?\128?\153 command help output
> string to :
>
>
> Why does the mail reflector mangle the commit messages? They look OK from
> svn?
>
> 0xe1 0x80 0x98 is UTF-8 for U-2018, LEFT SINGLE QUOTATION MARK. So I guess
> they really are UTF-8 and the mail client?
>
> Thanks,
>
> Andrew Fish
>
> ~/work/edk2>svn log -r15984
> ------------------------------------------------------------------------
> r15984 | jcarsey | 2014-08-29 13:02:38 -0700 (Fri, 29 Aug 2014) | 9 lines
>
> Cleanup UefiDpLib ‘dp’ command help output string to :
>  * Follow a consistent style
>  * Add consistent sections: NOTES, EXAMPLES, RETURN VALUES, etc.
>  * Wrap the text to fit in 80x25 formatted console output
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <[email protected]>
> Reviewed-by: Jaben Carsey <[email protected]>
>
> ------------------------------------------------------------------------
>
>
>
> * Follow a consistent style
> * Add consistent sections: NOTES, EXAMPLES, RETURN VALUES, etc.
> * Wrap the text to fit in 80x25 formatted console output
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <[email protected]>
> Reviewed-by: Jaben Carsey <[email protected]>
>
> Modified Paths:
> --------------
>    trunk/edk2/ShellPkg/Library/UefiDpLib/UefiDpLib.uni
>
> Modified: trunk/edk2/ShellPkg/Library/UefiDpLib/UefiDpLib.uni
> ===================================================================
> --- trunk/edk2/ShellPkg/Library/UefiDpLib/UefiDpLib.uni 2014-08-29 18:58:36
> UTC (rev 15983)
> +++ trunk/edk2/ShellPkg/Library/UefiDpLib/UefiDpLib.uni          2014-08-29
> 20:02:38 UTC (rev 15984)
> @@ -2,6 +2,8 @@
>  +    - --------------+ -++ -----++ \ No newline at end of file
>
> This was sent by the SourceForge.net collaborative development platform, the
> world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> edk2-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-commits
>
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> edk2-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-commits
>

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to