Looks like patch is missing new files from ShellPkg/Library/UefiBcfgCommandLib/ 
directory. UefiShellInstall1CommandsLib.h and .uni files are removed from its 
.inf file in the patch, but don't see those files deleted in the patch.

ShellPkg.dsc change:

  BcfgCommandLib|ShellPkg/Library/UefiBcfgCommandLib/UefiBcfgCommandLib.inf

Why not call it UefiShellBcfgCommandLib to remain consistent with other profile 
library naming convention for ShellPkg?

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, September 04, 2014 5:33 PM
To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command


Erik, Tapan, or Chris,



Can you check this out?



The goal of the pair of patches is to refactor out the bcfg command from being 
in both Install1 and Debug1 command libraries.  Instead each of those libraries 
will link in this library and the code will exist in only one place.



ShellPkg: Use the new library for "bcfg" command



Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Jaben Carsey 
<jaben.car...@intel.com<mailto:jaben.car...@intel.com>>
------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to