Reviewed-by: Chris Phillips <chr...@hp.com<mailto:chr...@hp.com>>
From: Phillips, Chris J (Plano, TX)
Sent: Friday, September 05, 2014 12:52 PM
To: Carsey, Jaben; Shah, Tapan; Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command
The UefiShellBcfgCommandLib.c code looks good. Fairly close to original with a
couple other fixes.
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, September 05, 2014 11:05 AM
To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>;
Carsey, Jaben
Subject: RE: [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command
Erik, Chris, and Tapan,
Here is an updated patch with the rename and comment fixed per Tapan and Chris.
I fixed the encoding on the UNI also.
Note: the code and UNI content here is copied and pasted from the
hopefully-soon-to-be-removed code except for the Register and Unregister
functions.
-Jaben
From: Carsey, Jaben
Sent: Thursday, September 04, 2014 3:33 PM
To: Shah, Tapan (tapands...@hp.com<mailto:tapands...@hp.com>); Phillips, Chris
J (BCS CFE) (chr...@hp.com<mailto:chr...@hp.com>); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>;
Carsey, Jaben
Subject: [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command
Erik, Tapan, or Chris,
Can you check this out?
The goal of the pair of patches is to refactor out the bcfg command from being
in both Install1 and Debug1 command libraries. Instead each of those libraries
will link in this library and the code will exist in only one place.
ShellPkg: Add a new library for "bcfg" command
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<jaben.car...@intel.com<mailto:jaben.car...@intel.com>>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
