Hi Ray,
The changes we did was to make UEFI SCT running on EFI Shell 2.0.
I am not exactly sure to remember why we made the change but I think it was
because SCT uses EFI_SHELL_PROTOCOL.Execute().
EDK Shell (the old shell) uses to return an error if the command failed.
The EFI Shell specification is a bit confusing on the returned status of
EFI_SHELL_PROTOCOL.Execute().
It says 'EFI_SUCCESS The command executed successfully. (...)'
If a command has successfully been started by the EFI Shell but failed. Can
we assume the 'command executed successfully'?
I do not mind to revert the change. But it would be nice to clarify the
Shell specification.
Maybe something like:
'EFI_SUCCESS The shell manages to start the command'
Thanks,
Olivier
From: Ni, Ruiyu [mailto:[email protected]]
Sent: 12 September 2014 08:58
To: Olivier Martin; 'Phillips, Chris J (BCS CFE) ([email protected])'
Cc: Kirmeier, Peter; [email protected]
Subject: RE: [edk2] [Patch]ShellPkg: Make shell image exit with exit code
instead of EFI_ABORTED while exit status is other than SHELL_SUCCESS.
Hi Oliver,
Why did you check in the patch to put the exit-code in ExitData? In my
opinion, unless Shell spec defines that the exit-code can be got from the
ExitData, putting the exit-code in ExitData and always returning EFI_ABORTED
doesn't make sense to the caller.
>From the current wording in the shell spec 2.1 (If exiting an instance of
the UEFI shell, the value that will be returned to the caller.), caller can
get the exit-code from StartImage()'s return status.
Thanks,
Ray
From: Phillips, Chris J (Plano, TX) [mailto:[email protected]]
Sent: Friday, September 12, 2014 2:12 AM
To: [email protected]; Kirmeier, Peter; Olivier Martin
Subject: Re: [edk2] [Patch]ShellPkg: Make shell image exit with exit code
instead of EFI_ABORTED while exit status is other than SHELL_SUCCESS.
Shumin,
Please wait for Olivier to look at this. I do not believe this change
should be made.
The Exit() boot service requires the second parameter to be of type
EFI_STATUS. Also, Olivier previously submitted a change so ExitData
contains NULL string followed by ExitStatus.
Thanks,
Chris
From: Carsey, Jaben [mailto:[email protected]]
Sent: Thursday, September 11, 2014 12:11 PM
To: Kirmeier, Peter; [email protected]; Olivier Martin
Subject: Re: [edk2] [Patch]ShellPkg: Make shell image exit with exit code
instead of EFI_ABORTED while exit status is other than SHELL_SUCCESS.
Reviewed-by: Jaben Carsey <[email protected]>
From: Kirmeier, Peter [mailto:[email protected]]
Sent: Wednesday, September 10, 2014 11:38 PM
To: [email protected]; Carsey, Jaben; Olivier Martin
Subject: RE: [edk2] [Patch]ShellPkg: Make shell image exit with exit code
instead of EFI_ABORTED while exit status is other than SHELL_SUCCESS.
Importance: High
Signed-off-by: Peter Kirmeier <[email protected]>
From: Qiu, Shumin [mailto:[email protected]]
Sent: Thursday, September 11, 2014 8:01 AM
To: Carsey, Jaben; Olivier Martin
Cc: [email protected]
Subject: [edk2] [Patch]ShellPkg: Make shell image exit with exit code
instead of EFI_ABORTED while exit status is other than SHELL_SUCCESS.
Hi Jaben and Olivier,
Could you help to review the patch? When exit status is not SHELL_SUCCESS
make the shell exit with the exit code instead of EFI_ABORTED.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <[email protected]>
Thanks,
Shumin
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
