The rollback looks good to me.
I did not doing any testing of it.
-Jaben
From: Ni, Ruiyu
Sent: Wednesday, September 17, 2014 2:54 AM
To: Olivier Martin; Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Return correct exit-code in "exit" command to
caller
Importance: High
Hi Olivier, Jaben,
The check in r15180 caused the shell always return EFI_ABORTED no matter what
exit-code user specifies for "exit" command. It's a critical bug for shell user
who does different things upon different exit-codes.
The issue is because the error status was returned in the ExitData. But I think
unless Shell spec defines that the exit-code can be got from the ExitData,
putting the exit-code in ExitData and always returning EFI_ABORTED doesn't make
sense to the caller.
>From the current wording in the shell spec 2.1 (If exiting an instance of the
>UEFI shell, the value that will be returned to the caller.), caller can get
>the exit-code from StartImage()'s return status.
So I would like to roll back this check in firstly to let "exit" command works
as expected. We can further discuss how to fix what the r15180 intended to fix.
The roll back caused some conflicts because some new changes in the same place
were made after this check in. So I worked out an almost "clean" roll back
patch and hope you can review whether it doesn't bring new issues.
Regards,
Ray
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
