Reviewed-by: Jaben Carsey <[email protected]>
From: Phillips, Chris J (Plano, TX) [mailto:[email protected]]
Sent: Wednesday, September 17, 2014 2:18 PM
To: Qiu, Shumin; Carsey, Jaben
Cc: [email protected]
Subject: RE: [edk2] [Patch] ShellPkg: Fix the support for command line comments.
Importance: High
Sorry for the delay.
Reviewed-by: Chris Phillips <[email protected]<mailto:[email protected]>>
From: Qiu, Shumin [mailto:[email protected]]
Sent: Sunday, September 14, 2014 9:24 PM
To: Phillips, Chris J (Plano, TX); Carsey, Jaben
Cc: [email protected]<mailto:[email protected]>
Subject: [edk2] [Patch] ShellPkg: Fix the support for command line comments.
Hi Chrisp and Jaben,
As the code logic for command line comments was added in 'RunCommand', when the
function was called nestedly some problems were caused:
1) Script a.nsh with content : echo ^#^# > a.txt. Execute the script.
Output: echo is on
Expected result: a.nsh is with content ##.
2) Script b.nsh with content: echo %1 > b.txt. Execute b.nsh "^#pattern
aa"
Output: The content in b.txt is "
Expected Result: The content in b.txt is "#pattern aa"
The attached patch seems fix these issues. Could you help review?
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <[email protected]<mailto:[email protected]>>
Thanks,
Shumin
------------------------------------------------------------------------------
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
