Version 2 is archived at
<http://thread.gmane.org/gmane.comp.bios.tianocore.devel/9579>.
The only change relative to v2 is in patch #4; the OemId and OemTableId
signature checks have been dropped. (See the Notes section of patch #4.)
The diff between the two versions is:
> diff --git a/OvmfPkg/AcpiPlatformDxe/Qemu.c b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> index 0e01c37..95512d1 100644
> --- a/OvmfPkg/AcpiPlatformDxe/Qemu.c
> +++ b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> @@ -974,23 +974,11 @@ Process2ndPassCmdAddPointer (
>
> if (Header->Length >= sizeof *Header &&
> Header->Length <= Blob2Remaining &&
> - CalculateSum8 ((CONST UINT8 *)Header, Header->Length) == 0 &&
> - (
> - (AsciiStrnCmp ((CONST CHAR8 *)Header->OemId, "BOCHS ",
> - sizeof Header->OemId) == 0 &&
> - AsciiStrnCmp ((CONST CHAR8 *)&Header->OemTableId, "BXPC", 4) == 0
> - ) ||
> - (CompareMem (Header->OemId, "BXPC\0", sizeof Header->OemId) == 0 &&
> - CompareMem (&Header->OemTableId, "BXDSDT\0",
> - sizeof Header->OemTableId) == 0
> - )
> - )
> - ) {
> + CalculateSum8 ((CONST UINT8 *)Header, Header->Length) == 0) {
> //
> // This looks very much like an ACPI table from QEMU:
> // - Length field consistent with both ACPI and containing blob size
> // - checksum is correct
> - // - 10-byte signature checks out
> //
> DEBUG ((EFI_D_VERBOSE, "found \"%-4.4a\" size 0x%x\n",
> (CONST CHAR8 *)&Header->Signature, Header->Length));
and the commit message has been updated accordingly.
This version has been tested the same way as v2.
I'm fine with either v2 or v3 being accepted. If there's no explicit
NACK, I'll push v3 no later than 2014-Sep-26 Friday morning, CEST
(UTC+02:00).
Thanks
Laszlo
Laszlo Ersek (4):
OvmfPkg: resolve OrderedCollectionLib with base red-black tree
instance
OvmfPkg: AcpiPlatformDxe: actualize QemuLoader.h comments
OvmfPkg: AcpiPlatformDxe: remove current ACPI table loader
OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader
interface
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 +
OvmfPkg/AcpiPlatformDxe/QemuLoader.h | 6 +-
OvmfPkg/AcpiPlatformDxe/Qemu.c | 753 +++++++++++++++++++---------
OvmfPkg/OvmfPkgIa32.dsc | 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgX64.dsc | 1 +
6 files changed, 529 insertions(+), 234 deletions(-)
--
1.8.3.1
------------------------------------------------------------------------------
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
