Bruce: Good catch. In fact, EfiRestUpdate is not UEFI standard Reset type. So, I suggest to remove this sentence from comments to reduce user confuse. The patch is attached.
MdePkg: Remove the redundant sentence in the function header of EfiResetSystem() API. EfiResetUpdate is not UEFI standard Reset type. Remove it from the function header of EfiResetSystem() API. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gao, Liming <[email protected]> Index: Include/Library/UefiRuntimeLib.h =================================================================== --- Include/Library/UefiRuntimeLib.h (revision 16026) +++ Include/Library/UefiRuntimeLib.h (working copy) @@ -329,8 +329,7 @@ Null-terminated Unicode string, optionally followed by additional binary data. The string is a description that the caller may use to further indicate the reason for the system reset. ResetData is only valid if ResetStatus is something other then EFI_SUCCESS. This pointer must be a physical - address. For a ResetType of EfiRestUpdate the data buffer also starts with a Null-terminated string - that is followed by a physical VOID * to an EFI_CAPSULE_HEADER. + address. **/ VOID Index: Library/UefiRuntimeLib/RuntimeLib.c =================================================================== --- Library/UefiRuntimeLib/RuntimeLib.c (revision 16026) +++ Library/UefiRuntimeLib/RuntimeLib.c (working copy) @@ -226,8 +226,7 @@ Null-terminated Unicode string, optionally followed by additional binary data. The string is a description that the caller may use to further indicate the reason for the system reset. ResetData is only valid if ResetStatus is something other then EFI_SUCCESS. This pointer must be a physical - address. For a ResetType of EfiRestUpdate the data buffer also starts with a Null-terminated string - that is followed by a physical VOID * to an EFI_CAPSULE_HEADER. + address. **/ VOID Thanks Liming -----Original Message----- From: Bruce Cran [mailto:[email protected]] Sent: Saturday, September 20, 2014 3:18 AM To: [email protected] Subject: [edk2] Typo in UefiRuntimeLib.h - 'EfiRestUpdate' Typo in MdePkg/Include/Library/UefiRuntimeLib.h line 332 "... For a ResetType of EfiRestUpdate the data buffer..." 'EfiRestUpdate' should be 'EfiResetUpdate'. -- Bruce ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
