Checked in code at R16189. Thanks, Eric
-----Original Message----- From: Dong, Eric [mailto:[email protected]] Sent: Monday, September 22, 2014 2:23 PM To: [email protected]; Tian, Feng Subject: Re: [edk2] [PATCH] MdeModulePkg/Universal: Fixed unused assigned variable Jaben, For this patch, the removed Status variable is truly useless. Two function use the status: For the change in MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c file, the function directly return the value without use the Status parameter. For the change in MdeModulePkg/Universal/SetupBrowserDxe/Setup.c file, browser check the return mFormDisplay pointer instead of check the Status code. Olivier, The patch is good. Reviewed-by: Eric Dong <[email protected]> Thanks, Eric -----Original Message----- From: Carsey, Jaben [mailto:[email protected]] Sent: Saturday, September 20, 2014 7:37 AM To: [email protected]; Tian, Feng Subject: Re: [edk2] [PATCH] MdeModulePkg/Universal: Fixed unused assigned variable Olivier, For the removing of the Status variable. Is it better to add a check to see if the function passed instead of (or in addition to) removing the variable? -Jaben > -----Original Message----- > From: Olivier Martin [mailto:[email protected]] > Sent: Friday, September 19, 2014 3:57 PM > To: Tian, Feng > Cc: [email protected] > Subject: [edk2] [PATCH] MdeModulePkg/Universal: Fixed unused assigned > variable > > Dear MdeModulePkg maintainer, > please review my attached patch that removes some unused assigned > variables. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Olivier Martin <[email protected]> > > Best Regards, > Olivier > > -- IMPORTANT NOTICE: The contents of this email and any attachments > are confidential and may also be privileged. If you are not the > intended recipient, please notify the sender immediately and do not > disclose the contents to any other person, use it for any purpose, or > store or copy the information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 ARM Holdings plc, > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in > England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Slashdot TV. Videos for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
