Hi,
After commit 7fe3fbad05cd6ef23e83ab5da8c5a82ff9bb456e ("ShellPkg:
Update MV. now supports across file system moves.") I can no longer
build OVMF using the following command line on Linux:
build -a X64 -t GCC48 -p OvmfPkg/OvmfPkgX64.dsc
Here's the error:
/home/somlo/KVM-OSX/SCRATCH/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c:510:7:
error: passing argument 1 of ???CreateFullDestPath??? from incompatible
pointer type [-Werror]
CreateFullDestPath(&DestPath, &FullDestPath, Node->FileName);
^
/home/somlo/KVM-OSX/SCRATCH/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c:309:1:
note: expected ???const CHAR16 **??? but argument is of type ???CHAR16 **???
CreateFullDestPath(
^
cc1: all warnings being treated as errors
make: ***
[/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC48/X64/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib/OUTPUT/Mv.obj]
Error 1
build.py...
: error 7000: Failed to execute command
make tbuild
[/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC48/X64/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib]
build.py...
: error F002: Failed to build module
/home/somlo/KVM-OSX/SCRATCH/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
[X64, GCC48, DEBUG]
- Failed -
and here's a quick patch that fixes it:
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
index 4dbc6d5..e3af4c8 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
@@ -507,7 +507,7 @@ ValidateAndMoveFiles(
SHELL_FREE_NON_NULL(FullDestPath);
FullDestPath = NULL;
if (ShellIsDirectory(DestPath)==EFI_SUCCESS) {
- CreateFullDestPath(&DestPath, &FullDestPath, Node->FileName);
+ CreateFullDestPath((CONST CHAR16 **)&DestPath, &FullDestPath,
Node->FileName);
}
//
Thanks,
--Gabriel
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
