On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote:
> On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm
> <leif.lindh...@linaro.org> wrote:
> > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote:
> > > >> > I guess that should be in addition to keeping it here?
> > > >>
> > > >> There is no need for those patterns at the root if they are ignored at
> > > >> the BaseTools directory level.
> > > >
> > > > There is until the next BaseTools sync.
> > >
> > > BaseTools trunk is now in EDK II, so the sync problem is gone.
> >
> > In which case, how about:
> >
> > >From acd1645a354e315aba1507dd27d95990691f38a4 Mon Sep 17 00:00:00 2001
> > From: Ryan Harkin <ryan.har...@linaro.org>
> > Date: Wed, 8 May 2013 16:18:34 +0100
> > Subject: [PATCH] Add .gitignore files
> >
> > While edk2 is still maintained in SVN, Many edk2 developers use git
> > for their main workflow, using the official mirrors.
> > Add a .gitignore and a BaseTools/.gitignore to prevents files
> > generated as part of the build from cluttering up "git status" output.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ryan Harkin <ryan.har...@linaro.org>
> > [removed Linaro-specific bits, rework for upstream]
> > Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>
> > ---
> > .gitignore | 6 ++++++
> > BaseTools/.gitignore | 11 +++++++++++
> > 2 files changed, 17 insertions(+)
> > create mode 100644 .gitignore
> > create mode 100644 BaseTools/.gitignore
> >
> > diff --git a/.gitignore b/.gitignore
> > new file mode 100644
> > index 0000000..918478d
> > --- /dev/null
> > +++ b/.gitignore
> > @@ -0,0 +1,6 @@
> > +*.d
> > +*.o
> > +*.pyc
>
> These should only be needed in BaseTools.
Would we want to not ignore these if they appeared elsewhere?
> > +Build/
> > +Conf/
>
> Can you move this to Conf/.gitignore as *?
Are these the final comments?
/
Leif
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
