Looks good to me. Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: Jordan Justen [mailto:[email protected]] > Sent: Tuesday, October 14, 2014 10:08 AM > To: [email protected]; Carsey, Jaben > Subject: Re: [edk2] [RFC v2] EDK II Contributions.txt: Update patch format > information > Importance: High > > On Mon, Sep 8, 2014 at 10:42 PM, Jordan Justen <[email protected]> > wrote: > > Update to show what the patch looks like in email form. > > > > NOTE: This does not modify the wording of the "TianoCore Contribution > > Agreement 1.0" section > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jordan Justen <[email protected]> > > Cc: Jaben Carsey <[email protected]> > > --- > > Jaben, all: How does this version look? > > ping > > > MdePkg/Contributions.txt | 42 > > +++++++++++++++++++++++++++++------------- > > 1 file changed, 29 insertions(+), 13 deletions(-) > > > > diff --git a/MdePkg/Contributions.txt b/MdePkg/Contributions.txt index > > 5dd8a47..1985677 100644 > > --- a/MdePkg/Contributions.txt > > +++ b/MdePkg/Contributions.txt > > @@ -34,9 +34,9 @@ To make a contribution to a TianoCore project, follow > these steps. > > Contributions using other licenses might be accepted, but further > > review will be required. > > > > -======================================= > > -= Change Description / Commit Message = > > -======================================= > > +===================================================== > > += Change Description / Commit Message / Patch Email = > > +===================================================== > > > > Your change description should use the standard format for a commit > > message, and must include your "Signed-off-by" signature @@ -44,7 > > +44,32 @@ and the "Contributed-under" message. > > > > == Sample Change Description / Commit Message = > > > > -=== Definitions for sample change description === > > +=== Start of sample patch email message === > > + > > +From: Contributor Name <[email protected]> > > +Subject: [PATCH] CodeModule: Brief-single-line-summary > > + > > +Full-commit-message > > + > > +Contributed-under: TianoCore Contribution Agreement 1.0 > > +Signed-off-by: Contributor Name <[email protected]> > > +--- > > + > > +An extra message for the patch email which will not be considered > > +part of the commit message can be added here. > > + > > +Patch content inline or attached > > + > > +=== End of sample patch email message === > > + > > +=== Notes for sample patch email === > > + > > +* The first line of commit message is taken from the email's subject > > + line following [PATCH]. The remaining portion of the commit message > > + is the email's content until the '---' line. > > +* git format-patch is one way to create this format > > + > > +=== Definitions for sample patch email === > > > > * "CodeModule" is a short idenfier for the affected code. For > > example MdePkg, or MdeModulePkg UsbBusDxe. > > @@ -58,15 +83,6 @@ and the "Contributed-under" message. > > * "Signed-off-by" is the contributor's signature identifying them > > by their real/legal name and their email address. > > > > -=== Start of sample change description / commit message === > > -CodeModule: Brief-single-line-summary > > - > > -Full-commit-message > > - > > -Contributed-under: TianoCore Contribution Agreement 1.0 > > -Signed-off-by: Contributor Name <[email protected]> -=== End > > of sample change description / commit message === > > - > > ======================================== > > = TianoCore Contribution Agreement 1.0 = > > ======================================== > > -- > > 2.1.0 > > > > > > ---------------------------------------------------------------------- > > -------- > > Want excitement? > > Manually upgrade your production database. > > When you want reliability, choose Perforce. > > Perforce version control. Predictably reliable. > > > http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg. > > clktrk _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
