On 10/23/14 01:40, Jordan Justen wrote: > On 2014-10-22 16:01:29, wrote: >> From: Reza Jelveh <reza.jel...@tuhh.de> >> >> The SataController is copied to OvmfPkg where the IdeController >> resides and enabled for OvmfPkg > > In http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/10187 > you wrote: "The PcAtChipsetPkg/DuetPkg remains untouched. The copy of > SataController is in OVMF as requested by the Intel guys." > > Where was this requested? > > Could this driver be made reasonably generic enough for DuetPkg and > OvmfPkg to both be able to use a common version residing in > PcAtChipsetPkg? Maybe the PcAtChipsetPkg owner doesn't think it would > be a good idea? (Or, maybe it is just not a good idea? I don't > know...) > > One thing I don't want is for OVMF to depend on DuetPkg.
This had been proposed before (with PcAtChipsetPkg and MdeModulePkg as possible new homes for SataControllerDxe), but no agreement was reached: In <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/8251/focus=8256>, Laszlo wrote: > Ray, can you please enlighten me why SataControllerDxe is under > DuetPkg and not MdeModulePkg? In <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/8251/focus=8288>, Star wrote: > I added SataControllerDxe in DuetPkg to support AHCI for Duet that > has chipset and platform specific initialization done before the Duet > boot. > It was thought to be hardly shared and used by real hardware > platforms as the platforms (at least all I touched) have their own > SataControllerDxe driver with some chipset policies or platform > configurations. (Obviously, those "platforms" are not open source, so we can't look at them.) Then, in <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/8467/focus=8471>, in the v1 patchset, Reza tried to move SataControllerDxe to PcAtChipsetPkg. In <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/8467/focus=8494>, Star wrote: > We will review it and get back to you. So, - SataControllerDxe had always been considered as platform-specific, - an attempt to move it to PcAtChipsetPkg didn't converge (in two months), - in patch v3 3/5, Reza customizes SataController anyway, which is much easier to do in OvmfPkg. Personally, I don't mind this deep copy. (It's not a reference into DuetPkg, but a real copy.) We're not forking a central package's module; we're copying from another "client" platform. Thanks Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
