On 10/23/14 08:05, Gao, Liming wrote:
> Somlo:
>
> Your patch shows four AcpiTimerLib instances: AcpiTimerLib.inf,
> BaseAcpiTimerLib.inf, BaseRomAcpiTimerLib.inf and DxeAcpiTimerLib.inf.
>
> I find BaseAcpiTimerLib.inf includes DxeAcpiTimerLib.c [...]
Well that's the error right there (I haven't looked at the tarball yet).
"BaseAcpiTimerLib" is supposed to be one of the library instances that
is usable in lower level modules, where dynamic PCDs are not available.
BaseAcpiTimerLib.inf doesn't list PcdLib in the [LibraryClasses] section
for a good reason: there's no usable PCD library (for dynamic PCDs) for
eg. DXE_CORE, which is what BaseAcpiTimerLib targets.
Here's a summary how the sources are referenced by the inf files after
the patch in question:
BaseAcpiTimerLib.inf:
[Sources]
AcpiTimerLib.c
DxeAcpiTimerLib.c <------- bug
BaseRomAcpiTimerLib.inf:
[Sources]
AcpiTimerLib.c
BaseRomAcpiTimerLib.c
DxeAcpiTimerLib.inf:
[Sources]
AcpiTimerLib.c
DxeAcpiTimerLib.c
In short: Gabriel, you forgot to update
DxeAcpiTimerLib.c --> BaseAcpiTimerLib.c
under [Sources] in "BaseAcpiTimerLib.inf".
Thanks
Laszlo
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
