Reviewed-by: Jaben Carsey <[email protected]> (I had noticed it anyways)
-----Original Message----- From: Olivier Martin [mailto:[email protected]] Sent: Thursday, October 30, 2014 7:30 AM To: Carsey, Jaben Cc: [email protected]; Mcdaniel, Daryl Subject: RE: [PATCH] ShellPkg: Fixed variable set but never used Importance: High Sorry, I have just realized I sent the patch to the wrong maintainer. > -----Original Message----- > From: Olivier Martin [mailto:[email protected]] > Sent: 30 October 2014 11:55 > To: [email protected] > Cc: [email protected]; Olivier Martin > Subject: [PATCH] ShellPkg: Fixed variable set but never used > > This warning/error raised by ARM toolchain prevents to build > the EFI Shell for ARM 32-bit with this toolchain. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Olivier Martin <[email protected]> > --- > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > index b4cf682..4921f28 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > @@ -898,7 +898,6 @@ AddNewGuidNameMapping( > IN CONST CHAR8 *Lang OPTIONAL > ) > { > - CONST GUID_INFO_BLOCK *Temp; > EFI_STRING_ID NameID; > > HandleParsingHiiInit(); > @@ -907,7 +906,7 @@ AddNewGuidNameMapping( > return (EFI_INVALID_PARAMETER); > } > > - if ((Temp = InternalShellGetNodeFromGuid(Guid)) != NULL) { > + if ((InternalShellGetNodeFromGuid(Guid)) != NULL) { > return (EFI_ACCESS_DENIED); > } > > -- > 2.1.1 ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
