On Mon, 2014-11-03 at 08:38 +0000, Fan, Jeff wrote: > Chen, > > +/** > + Initialize Multi-processor support. > + > +**/ > +VOID InitializeMpSupport ( > + VOID > + ); > > Missing Enter between VOID and InitializeMpSupport() in CpuMp.h >
Got it. Thanks, Chen > Thanks! > Jeff > > -----Original Message----- > From: Chen Fan [mailto:chen.fan.f...@cn.fujitsu.com] > Sent: Monday, October 27, 2014 5:30 PM > To: edk2-devel@lists.sourceforge.net > Cc: Fan, Jeff; Jordan Justen; Justen, Jordan L > Subject: [RFC PATCH v6 01/27] UefiCpuPkg/CpuDxe: Add no-op InitializeMpSupport > > From: Jordan Justen <jordan.l.jus...@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > UefiCpuPkg/CpuDxe/CpuDxe.c | 3 +++ > UefiCpuPkg/CpuDxe/CpuDxe.inf | 2 ++ > UefiCpuPkg/CpuDxe/CpuMp.c | 28 ++++++++++++++++++++++++++++ > UefiCpuPkg/CpuDxe/CpuMp.h | 27 +++++++++++++++++++++++++++ > 4 files changed, 60 insertions(+) > create mode 100644 UefiCpuPkg/CpuDxe/CpuMp.c create mode 100644 > UefiCpuPkg/CpuDxe/CpuMp.h > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c index > f165e17..c9df4e1 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.c > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c > @@ -13,6 +13,7 @@ > **/ > > #include "CpuDxe.h" > +#include "CpuMp.h" > > // > // Global Variables > @@ -897,6 +898,8 @@ InitializeCpu ( > ); > ASSERT_EFI_ERROR (Status); > > + InitializeMpSupport (); > + > return Status; > } > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.inf b/UefiCpuPkg/CpuDxe/CpuDxe.inf > index 152a091..e49548f 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.inf > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.inf > @@ -46,6 +46,8 @@ > CpuDxe.c > CpuDxe.h > CpuGdt.c > + CpuMp.c > + CpuMp.h > > [Sources.IA32] > Ia32/CpuAsm.asm | MSFT > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c new file > mode 100644 index 0000000..c8189bc > --- /dev/null > +++ b/UefiCpuPkg/CpuDxe/CpuMp.c > @@ -0,0 +1,28 @@ > +/** @file > + CPU DXE Module. > + > + Copyright (c) 2008 - 2014, Intel Corporation. All rights > + reserved.<BR> This program and the accompanying materials are > + licensed and made available under the terms and conditions of the BSD > + License which accompanies this distribution. The full text of the > + license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +**/ > + > +#include "CpuDxe.h" > +#include "CpuMp.h" > + > +/** > + Initialize Multi-processor support. > + > +**/ > +VOID > +InitializeMpSupport ( > + VOID > + ) > +{ > +} > + > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h new file > mode 100644 index 0000000..9468212 > --- /dev/null > +++ b/UefiCpuPkg/CpuDxe/CpuMp.h > @@ -0,0 +1,27 @@ > +/** @file > + CPU DXE MP support > + > + Copyright (c) 2006 - 2014, Intel Corporation. All rights > + reserved.<BR> This program and the accompanying materials are > + licensed and made available under the terms and conditions of the BSD > + License which accompanies this distribution. The full text of the > + license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +**/ > + > +#ifndef _CPU_MP_H_ > +#define _CPU_MP_H_ > + > +/** > + Initialize Multi-processor support. > + > +**/ > +VOID InitializeMpSupport ( > + VOID > + ); > + > +#endif // _CPU_MP_H_ > + > -- > 1.9.3 > ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
