Hello Dennis, Thanks for backslash fix plan needed for Windows hosted gcc. Now I see why I thought your patch didn't convert [C-Code-File]. I had applied your patch on top of the pending patch for Windows hosted gcc, and that caused the first part of your patch to be rejected.
Thanks, Scott -----Original Message----- From: Liu, Yingke D [mailto:yingke.d....@intel.com] Sent: Thursday, November 06, 2014 06:55 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] [BaseTools] Put all include search paths of a module into a file Hi Scott, Thanks for your comments. I will replace '\\' with '/' by using the same rule used in object files and static library files. This patch applied to all sections including [C-Code-File] which is the first several lines in this patch :) Thanks, Dennis -----Original Message----- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Thursday, November 06, 2014 10:56 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] [BaseTools] Put all include search paths of a module into a file Liu, Yingke D [mailto:yingke.d....@intel.com] wrote: ]Dear All, ] ]This patch is going to put all -I or /I options followed by include search path into a ]file (inc.lst) just as object files and static library files. There are cases that too ]many /I options on the command line, and NMAKE fails due to command-line length limitation. ] ]Please let me know any impact of this patch to you. ] ]Thanks, ]Dennis Hello Dennis, This patch is not working with Windows hosted gcc tools. The cause is the single back slash path separator. I believe a single back slash in a gcc response file is interpreted as a continuation character. The solution is to use either '/' or '\\' as the path separator. When the include files are on the command line, I believe the mingw library code for path processing fixes the back slash problem. But when a response file is used, the file continuation character processing runs before the path processing code has a chance to reverse the back slashes. A question, why is the change not applied to [C-Code-File]? Isn't the $(CC) command it generates the worst case for command line length? Thanks, Scott ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
