I like the other patch more. The ASSERT is specifically to warn a developer if the code changes such that it won't function. We don't want to skip based on that as it should be guaranteed by preceding code.
From: Qiu, Shumin Sent: Thursday, November 06, 2014 7:23 PM To: Carsey, Jaben Cc: [email protected] Subject: RE: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005 Importance: High Hi Jaben, Patch updated. Could you help review? Thanks, Shumin From: Qiu, Shumin [mailto:[email protected]] Sent: Friday, November 07, 2014 9:27 AM To: Carsey, Jaben Cc: [email protected]<mailto:[email protected]> Subject: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005 Hi Jaben, Could you help review the patch? The patch adds type cast to avoid build failure in VS2005. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <[email protected]<mailto:[email protected]>> Thanks, Shumin
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
