On Thu, Nov 13, 2014 at 04:50:05PM -0800, Jordan Justen wrote: > On 2014-11-13 12:12:54, Gabriel L. Somlo wrote: > > New in v.6: > > > > - ASSERT(FALSE) in default branch of HostBridgeDevID switch followed > > by return statement to suppress unused variable gcc warnings > > (Jordan, thanks for being OK with that, I really believe if we ever > > do end up with a dev ID other than PIIX4 or Q35 we do want to be > > made aware of it! :) > > > > - patch 9/9 (dynamic IRQ Line initialization) now works on non-root > > buses and pci-to-pci bridges, 100% matching SeaBIOS behavior. > > I committed 1-8. For 9, I thought I might let it simmer to see if > it gets more review.
Thanks ! That happens to work out great, since I have a teeny-tiny corner-case errata for 9, which probably nobody would have hit in 100 years, but still. I'll follow up with a version 7 (for patch #9 only) later tonight, so if anyone's about to review it, that's the one to look at. > By the way. Did you ever notice an OS that had a problem if these > weren't set? I was thinking that the ACPI information generally > provides what the OS needs for int line routing. Yeah, OS X (Mavericks is the one I'm playing with). If the IRQ Line registers don't hold the correct values, things like UHCI1 and UHCI2 fail to initialize properly. You may recall a lengthy thread about me wondering why that might be, back a while ago :) > > > - updated https://github.com/gsomlo/edk2 > > Thanks! I appreciate just having to git fetch to get the patches. > > My only recommendation is that you might consider using a branch named > based on the series. Next time I'm working on a lengthy series like this one I'll make sure to do that. Thanks, --Gabriel ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
